Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

!!! FEATURE: Upgrade ckeditor from 16.x to 35.x #3208

Closed
wants to merge 1 commit into from

Conversation

JamesAlias
Copy link
Contributor

@JamesAlias JamesAlias commented Oct 6, 2022

closes: #2836

What I did
Upgrade CKEditor to current stable version (35.x) as preparation to introduce new CKEditor Plugins to Neos.

How I did it

How to verify it

@mhsdesign
Copy link
Member

mhsdesign commented Oct 8, 2022

our hand copied table and inline widget css may need to be adjusted

/* This CSS code was extracted by hand from CKE build and some colors were altered.
It's not worth to set up proper CKE theme build as we only need this code for the table feature currently.
Feel free to remove it and setup a proper CKE styles build together with a custom theme. */

:global(.ck-content .table table td) {

a note about updating ck: https://neos-project.slack.com/archives/C07QEQ1U2/p1664789241021679?thread_ts=1664545321.750739&cid=C07QEQ1U2

(from @Reinmar )

@mhsdesign mhsdesign changed the title TASK: Upgrade ckeditor from 16.x to 35.x !!! FEATURE: Upgrade ckeditor from 16.x to 35.x Oct 8, 2022
@JamesAlias
Copy link
Contributor Author

Will give it a go again when we merged the build stack update. #3200

@JamesAlias JamesAlias closed this Oct 8, 2022
@mhsdesign mhsdesign deleted the feature/upgrade-ckeditor-v35 branch November 27, 2022 09:10
@crydotsnake
Copy link
Member

Hello everyone!

Since #3200 is merged, can we start this topic again?

@mhsdesign
Copy link
Member

I know @markusguenther experimented also a bit already but stopped eventually, maybe you (markus) can document the hurdles you found in #2836?

But sure this project can be continued ^^ I currently am focused on neos 9 but feel free to experiment ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade CKEditor5 to v37
3 participants