Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK: Allow node v16 for 7.3...8.1 #3566

Closed
mhsdesign opened this issue Jul 6, 2023 · 8 comments · Fixed by #3589
Closed

TASK: Allow node v16 for 7.3...8.1 #3566

mhsdesign opened this issue Jul 6, 2023 · 8 comments · Fixed by #3589
Labels
7.3 8.0 8.1 DX This issue, once solved, might improve the Developer Experience for Neos Integrators. Technical debt

Comments

@mhsdesign
Copy link
Member

On my mac, i simply cant get node 14 to run - and so far everything seems to work with node 16 as well.

@crydotsnake
Copy link
Member

Use nvm for managing your node versions :)

@mhsdesign
Copy link
Member Author

any opinions @grebaldi or @markusguenther? i mean we dont have to use it in ci, but if it works id like to allow it so i dont have to edit package.json all the time 😂 (again Node 14 doesnt work or sth on my system - and i like 16 better xD)

@grebaldi
Copy link
Contributor

grebaldi commented Aug 7, 2023

@mhsdesign

If it builds, v16 ought to be fine. I don't think it collides with anything (and I'm sure I've run it accidentally in my local environment on 7.3 without issues :D).

@crydotsnake

Use nvm for managing your node versions :)

I'd like to recommend https://github.com/Schniz/fnm instead - it's the much faster option.

@mhsdesign mhsdesign linked a pull request Aug 7, 2023 that will close this issue
@mhsdesign
Copy link
Member Author

When we allowed Node 16 for newer branches we first stumbled upon a problem, that some unit test didnt work: #2980

Also in the final pr for 8.1 there are some other files change. Im just thinking of backporting it?
#3075

@mhsdesign
Copy link
Member Author

mhsdesign commented Aug 8, 2023

One of the adjustments in #3075 was related to DevExpress/testcafe#7097 which is now closed so it might be we can clean up this snippet in the e2e tests?

https://github.com/neos/neos-ui/blob/5881ede007f21fd03449d43e0717a03255b946c1/Tests/IntegrationTests/utils.js#L31C63-L34

interestingly, i dindt encounter any issues when running the e2e test on 8.0 #3560 (i ran them on 8.0 and node 16)

@mhsdesign
Copy link
Member Author

But the fetch polyfill introduced with #3075

can definitely be backported

@grebaldi
Copy link
Contributor

I'm not so sure there actually. Native fetch would require Node >= v16.15.0 (https://nodejs.org/en/blog/release/v16.15.0), and in v16, it is still behind a flag (v18 LTS removes that).

@grebaldi grebaldi added Technical debt DX This issue, once solved, might improve the Developer Experience for Neos Integrators. 7.3 8.0 8.1 labels Jan 8, 2024
@grebaldi
Copy link
Contributor

grebaldi commented Jan 8, 2024

solved by: #3589

@grebaldi grebaldi closed this as completed Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
7.3 8.0 8.1 DX This issue, once solved, might improve the Developer Experience for Neos Integrators. Technical debt
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants