Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: reference type in creation dialog doesn't work #3615

Closed
1 task done
tellenrieder opened this issue Sep 12, 2023 · 2 comments · Fixed by #3519
Closed
1 task done

BUG: reference type in creation dialog doesn't work #3615

tellenrieder opened this issue Sep 12, 2023 · 2 comments · Fixed by #3519
Labels
9.0 Bug Label to mark the change as bugfix

Comments

@tellenrieder
Copy link

tellenrieder commented Sep 12, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Description

Using a property with reference type in the creation dialog in Neos 9 does not create the module and shows a red popup message with
Given property "myProperty" is declared as "reference" in node type "My.Site:Foo.Bar" and must be treated as such.
The selection of a page in the CD works as desired.

YAML

    myProperty:
      type: reference
      ui:
        label: 'My Reference Property'
        showInCreationDialog: true
        inspector:
          editor: 'Neos.Neos/Inspector/Editors/ReferenceEditor'
          editorOptions:
            nodeTypes: [ 'My.Site:Document.Page ]
      validation:
        Neos.Neos/Validation/NotEmptyValidator: {}

Steps to Reproduce

  1. define a property of the reference type with showInCreationDialog: true
  2. create the module in Neos and select a page
  3. click 'Create New'

Expected behavior

  • module is created with the correct selected page as value for this property

Actual behavior

  • module isn't created
  • error popup appears

Affected Versions

Neos 9 (not sure if the bug appeared since Neos 9 or even earlier)
PHP 8.2

neos/neos-ui - 9.0.x-dev 684bb2f
neos/neos-ui-compiled - 9.0.x-dev 9115a2e

Relates: neos/neos-development-collection#4549

@mhsdesign mhsdesign added 9.0 Bug Label to mark the change as bugfix labels Sep 16, 2023
@ahaeslich
Copy link
Member

@skurfuerst I just found this entry on our project board which isn't an issue yet:

CreationDialogPropertiesCreationHandler: Do references work? (they won't) -> how to fix them? We need to create multiple commands after the first one -> NEW API!!!

Doesn't that fit to this bug report?

@mhsdesign
Copy link
Member

With #3519 we will introduce a new API capable of this. And can easily fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
9.0 Bug Label to mark the change as bugfix
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants