Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Integer validator with trailing chars #2081

Merged
merged 4 commits into from Sep 26, 2018

Conversation

mstruebing
Copy link
Contributor

@mstruebing mstruebing commented Aug 20, 2018

closes #2080
So - the error should be somewhere else, not in the validator itself as the test is running through.

Edit:
There is a paradox test case, can someone explain this behaviour?

Ok found it, tests are running but doesn't think these are tests, tests-runner think's tests should be one level deeper:

$ yarn jest -- -w 2 --coverage                                                                                                                                                                                                               
$ NODE_ENV=test jest -w 2 --coverage                                                                                                                                                                                                         
No tests found                                                                                                                                                                                                                               
  32 files checked.                                                                                                                                                                                                                          
  roots: /home/maex/projects/contrib/neos-base-distribution/Packages/Application/Neos.Neos.Ui/packages/neos-ui-validators - 32 matches                                                                                                       
  testMatch: ./src/**/?(*.)spec.js - 0 matches                                                                                                                                                                                               
  testPathIgnorePatterns: /node_modules/ - 32 matches\

propbably some issue with: https://github.com/neos/neos-ui/blob/master/packages/jest-preset-neos-ui/jest-preset.json#L18

@mstruebing mstruebing changed the title TASK: Add testcase BUGFIX: Integer validator with trailing chars Aug 20, 2018
@mstruebing mstruebing changed the title BUGFIX: Integer validator with trailing chars WIP BUGFIX: Integer validator with trailing chars Aug 20, 2018
@mstruebing mstruebing changed the title WIP BUGFIX: Integer validator with trailing chars BUGFIX: Integer validator with trailing chars Sep 18, 2018
@mstruebing
Copy link
Contributor Author

The error was indeed from the IntegerValidator and should be fixed now by this PR @dennisirmscher

@mstruebing
Copy link
Contributor Author

I'm interpreting the 👍 from @dennisirmscher as a positive review and therefore merge.

@mstruebing mstruebing merged commit cb4ff46 into neos:master Sep 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant