Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Allow additional options to inline link editor #2736

Conversation

gerhard-boden
Copy link
Contributor

Make it possible to pass options to the inline link editor through configuration, so the inline link editor is fully configurable like the link editor within the inspector.

resolves: #2710

@gerhard-boden
Copy link
Contributor Author

This is targeting 4.0 intentionally, since this was (unofficially?) possible before, but stopped working after f843688

Make it possible to pass options to the inline link editor through
configuration, so the inline link editor is fully configurable like the
link editor within the inspector.

resolves: neos#2710
@gerhard-boden gerhard-boden force-pushed the feature-add-more-options-to-inline-link-editor branch from cabbfba to 5c29bdc Compare May 27, 2020 17:11
@Sebobo
Copy link
Member

Sebobo commented Jul 3, 2020

If this is a feature we cannot put it into 4 or 5.0 - 5.2. So either we agree its a bugfix or have it in 5.3

@Sebobo
Copy link
Member

Sebobo commented Jul 3, 2020

I think we can simply have this as bugfix. I mean it apparently worked before and should work again.
The solution is also okay I think, but then we have to also extend the docs and the schema file.
Would it work exactly like it did before?

@gerhard-boden
Copy link
Contributor Author

gerhard-boden commented Jul 3, 2020

I'm really not sure if it was ever documented before, but people obviously expected the inline link editor to be configurable like the link editor within the inspector (we never said it wasn't). I don't think it would break anything if we merged it as a bugfix or surprise anyone, although I would also be okay to merge it as feature for 5.3. I mean if you have configuration in place that currently does nothing it would work after the update, but nobody would configure something and expect the configuration to have no effect I guess 😂

Where should I provide the documentation how to configure the inline link editor?

@gerhard-boden
Copy link
Contributor Author

I can also adjust my commit prefix after we made a final decision

@Sebobo Sebobo self-requested a review July 4, 2020 05:45
@Sebobo
Copy link
Member

Sebobo commented Jul 4, 2020

The docs are actually in Neos.Neos in the PropertyReferenceEditor. So would be a PR there as soon as we finished this.
Ah and I see the schema file doesn't contain the formatting and linking options yet.
Would maybe then be another PR to extend that from the Neos UI package then.

@gerhard-boden
Copy link
Contributor Author

Ah, that part of the documentation I did find, but I thought it was limited to the inspector editors, since I thought it was an "implementation secret" that we use the same React component within the CK Editor and the inspector. Since we have no other place I guess it's the most logical?

@Sebobo Sebobo changed the title FEATURE: Add additional options to inline link editor BUGFIX: Allow additional options to inline link editor Jul 7, 2020
@Sebobo Sebobo merged commit d9aae45 into neos:4.0 Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants