Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: Adds restore button for user impersonation #3091

Merged
merged 2 commits into from
Mar 24, 2022

Conversation

markusguenther
Copy link
Member

With Neos 8.0 we introduce the impersonation feature. So, it is possible to impersonate as a different user from the user management module.

This change will add related endpoints to the neos-ui to be able to communicate with the Neos.Neos API. The impersonation state will be saved in the Redux store, and a saga handles the restore of the origin user.

Besides the data handling stuff, we also add a new button to the user menu.

Related Neos PR:
neos/neos-development-collection#3648

Screen.Recording.2022-03-24.at.15.25.36.mp4

With Neos 8.0 we introduce the impersonation feature. So, it is possible to impersonate as a different user from the user management module.

This change will add related endpoints to the neos-ui to be able to communicate with the Neos.Neos API. The impersonation state will be saved in the Redux store, and a saga handles the restore of the origin user.

Besides the data handling stuff, we also add a new button to the user menu.

Related Neos PR:
neos/neos-development-collection#3648
@markusguenther
Copy link
Member Author

It works locally, as the e2e tests make issues since the 8.0 Neos changes. I need to rework the CircleCI stuff.
Currently I am not so confident in the CircleCI tests.

@markusguenther
Copy link
Member Author

Screenshot 2022-03-24 at 16 21 36

Test failing because the backend is not able to start, and the URI is not available.

@markusguenther
Copy link
Member Author

The URI from Neos.Neos was missing. Added now a check and hopefully, it is more robust.

@markusguenther
Copy link
Member Author

OK now just the test after the second site import fails. And that happens since the PHP 8.0 change.
Screenshot 2022-03-24 at 16 59 22

@markusguenther markusguenther added Feature Label to mark the change as feature 8.0 labels Mar 24, 2022
@kdambekalns kdambekalns merged commit a417bc9 into neos:master Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.0 Feature Label to mark the change as feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants