Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: ckeditor download option #3197

Merged

Conversation

NicoleNitschke
Copy link
Collaborator

@NicoleNitschke NicoleNitschke commented Oct 5, 2022

What I did

  • added option "downloadable" to the CkEditor in link editor options
  • changed link editor checkbox styling - label is now beside instead below the checkbox

How I did it

  • added the new checkbox similary to "nofollow" and "target='_blank'" options

How to verify it

  • check it out, in your ckeditor options add the following in your yaml:
    text:
      type: string
      ui:
        inline:
          editorOptions:
            linking:
              download: true

Before:

grafik

After:

grafik

Note: the new option needs to be added to the documentation

@NicoleNitschke NicoleNitschke marked this pull request as ready for review October 5, 2022 13:23
@kitsunet kitsunet changed the title Feature/8.1 ckeditor download option FEATURE: ckeditor download option Oct 5, 2022
@Sebobo
Copy link
Member

Sebobo commented Oct 6, 2022

Thx!
We will need an additional PR to adjust the docs in Neos.Neos/Documentation/References/PropertyEditorReference.rst

Copy link
Member

@Sebobo Sebobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please target 8.2

@kdambekalns kdambekalns changed the base branch from 8.1 to 8.2 October 6, 2022 08:01
@kdambekalns kdambekalns self-requested a review October 6, 2022 08:01
@crydotsnake
Copy link
Member

Thx! We will need an additional PR to adjust the docs in Neos.Neos/Documentation/References/PropertyEditorReference.rst

I've created the pull request: neos/neos-development-collection#3912

@Sebobo
Copy link
Member

Sebobo commented Oct 7, 2022

Works as expected :)

@kdambekalns kdambekalns merged commit 7665b05 into neos:8.2 Oct 7, 2022
@NicoleNitschke NicoleNitschke deleted the feature/8.1-ckeditor-download-option branch March 11, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants