Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: Remove 1K Dependencies & and separat webpack adapter extensibility package #3382

Merged
merged 19 commits into from Mar 6, 2023

Conversation

mhsdesign
Copy link
Member

@mhsdesign mhsdesign commented Feb 18, 2023

i started cleaning up more than initially thought with #3366 so this pr is made ontop on it ;)

solves: #3215

What i did:

  • make @neos-project/neos-ui-extensibility a code only repo (eg no webpack, only the extensibilityMap.json and the shim js files)
  • fix the shims code es transpilation (they are now also build by typescript into the dist folder)
  • combine the webpack buildscript from @neos-project/neos-ui-extensibility and @neos-project/build-essentials into @neos-project/neos-ui-extensibility-webpack-adapter
  • remove @neos-project/babel-preset-neos-ui (was forgotten)
  • introduce new private @neos-project/neos-ui-build for all the esbuild specific plugins and other build scripts (this package will not be released)
  • use an easy official plugin point to still have the package @neos-project/neos-ui-extensibility-webpack-legacy installed in the workspace but not its dependencies (we dont need webpack and babel anymore)
  • remove storybook as dependency (looots of dependencies)
  • remove 8year old git hook and init script no one uses :P (plus dependencies)
  • remove outdated things from the Build/ folder in general
  • remove ./docker-compose.yaml which is completely outdated and unused (uses node14 + webpack for building the ui, but we rather use node natively)
  • remove unused clean command from each package gpristine is your friend ;)
  • removed crossenv as we dont use NODE_ENV anymore to control the build
  • extensibilty alias map as json: packages/neos-ui-extensibility/extensibilityMap.json

Todos:

  • remove whole .story-book folder (separate pr for removing all stories)
  • yarn dedupe '@babel/*'
  • yarn dedupe prop-types

.yarnrc.yml Outdated Show resolved Hide resolved
@mhsdesign mhsdesign changed the title Feature: Remove 1K Dependencies & esbuild extensibility FEATURE: Remove 1K Dependencies & esbuild extensibility Feb 18, 2023
@mhsdesign mhsdesign force-pushed the feature/cssBuildRefactor branch 3 times, most recently from 380def9 to eefb66d Compare February 22, 2023 07:46
Base automatically changed from feature/cssBuildRefactor to 8.3 February 22, 2023 14:34
@markusguenther markusguenther force-pushed the feature/cleanup5AndEsbuildExtensibility branch from 7b7348d to 890b4d3 Compare February 22, 2023 14:48
@github-actions github-actions bot added Feature Label to mark the change as feature 8.3 labels Feb 22, 2023
@mhsdesign mhsdesign force-pushed the feature/cleanup5AndEsbuildExtensibility branch from 5cf890a to 7b7348d Compare February 22, 2023 15:07
@mhsdesign mhsdesign marked this pull request as ready for review February 22, 2023 15:28
@mhsdesign
Copy link
Member Author

mhsdesign commented Feb 22, 2023

Ready to review.

Left over todos and discussions about the naming of the package @neos-project/neos-ui-extensibility-webpack-legacy will be handled in another pr - as otherwise things will get out of hand :D

Todos for next time:

require("esbuild").build({
    logLevel: "info",
    bundle: true,
    target: "es2020",
    entryPoints: {"Plugin": "src/index.js"},
    loader: {
        ".js": "tsx",
    },
    alias: require("@neos-project/neos-ui-extensibility/extensibilityMap.json"),
    outdir: "../../Public/NeosUserInterface",
})

@mhsdesign mhsdesign changed the title FEATURE: Remove 1K Dependencies & esbuild extensibility FEATURE: Remove 1K Dependencies & and separat webpack legacy extensibility Feb 22, 2023
@mhsdesign mhsdesign changed the title FEATURE: Remove 1K Dependencies & and separat webpack legacy extensibility FEATURE: Remove 1K Dependencies & and separat webpack legacy extensibility package Feb 22, 2023
@mhsdesign
Copy link
Member Author

i discussed the naming of @neos-project/neos-ui-extensibility-webpack-legacy with @fcool and we came to the conclusion to name it: @neos-project/neos-ui-extensibility-webpack-adapter

@mhsdesign
Copy link
Member Author

mhsdesign commented Feb 28, 2023

I just released a 8.3.0-beta1 8.3.0-beta2 8.3.0-beta3 for all the npm packages, so we can test this properly ;)

@mhsdesign mhsdesign force-pushed the feature/cleanup5AndEsbuildExtensibility branch from 7cf06c0 to e502b36 Compare February 28, 2023 15:13
@mhsdesign mhsdesign force-pushed the feature/cleanup5AndEsbuildExtensibility branch from e502b36 to 15993f9 Compare February 28, 2023 15:18
@mhsdesign mhsdesign changed the title FEATURE: Remove 1K Dependencies & and separat webpack legacy extensibility package FEATURE: Remove 1K Dependencies & and separat webpack adapter extensibility package Mar 1, 2023
mhsdesign and others added 3 commits March 2, 2023 16:49
# Conflicts:
#	packages/babel-preset-neos-ui/src/index.js
#	packages/build-essentials/package.json
#	packages/neos-ui-backend-connector/package.json
#	packages/neos-ui-constants/package.json
#	packages/neos-ui-contentrepository/package.json
#	packages/neos-ui-decorators/package.json
#	packages/neos-ui-editors/package.json
#	packages/neos-ui-extensibility/package.json
#	packages/neos-ui-guest-frame/package.json
#	packages/neos-ui-i18n/package.json
#	packages/neos-ui-inspector/package.json
#	packages/neos-ui-redux-store/package.json
#	packages/neos-ui-sagas/package.json
#	packages/neos-ui-validators/package.json
#	packages/neos-ui-views/package.json
#	packages/neos-ui/package.json
#	packages/positional-array-sorter/package.json
#	packages/react-proptypes/package.json
#	packages/utils-helpers/package.json
#	packages/utils-logger/package.json
#	packages/utils-redux/package.json
#	yarn.lock
@markusguenther
Copy link
Member

It looks good to me and I like the @neos-project/neos-ui-extensibility-webpack-adapter more than the legacy ... so thanks to @fcool :)

Again a remarkable but not so handsome PR ;)

Copy link
Member

@markusguenther markusguenther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥

@mhsdesign mhsdesign merged commit 9435ead into 8.3 Mar 6, 2023
3 checks passed
@mhsdesign mhsdesign deleted the feature/cleanup5AndEsbuildExtensibility branch March 6, 2023 15:24
mhsdesign added a commit that referenced this pull request Mar 27, 2023
mhsdesign added a commit that referenced this pull request Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.3 Feature Label to mark the change as feature
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants