Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Show full labels in nodetrees if possible #3663

Merged
merged 1 commit into from Dec 16, 2023

Conversation

Sebobo
Copy link
Member

@Sebobo Sebobo commented Nov 8, 2023

What I did

Previously labels were cut even if there would have been enough space due to the constraint to 264px.
Also since 8.3 the trees can be resized and the labels didn’t adjust to the increased width.

How I did it

Now they will use the available width via CSS.

How to verify it

Before:

Bildschirmfoto 2023-11-08 um 15 31 58 Bildschirmfoto 2023-11-08 um 15 31 51

After:

Bildschirmfoto 2023-11-08 um 15 32 17 Bildschirmfoto 2023-11-08 um 15 32 10

Previously labels were cut even if there would have been
enough space due to the constraint to 264px.
Also since 8.3 the trees can be resized and the labels
didn’t adjust to the increased width.
Now they will use the available width.
@Sebobo Sebobo added Bug Label to mark the change as bugfix 8.3 labels Nov 8, 2023
@Sebobo
Copy link
Member Author

Sebobo commented Nov 9, 2023

Cannot reproduce the e2e problem with drag & drop

@Sebobo Sebobo requested a review from ahaeslich November 9, 2023 13:18
@jonnitto
Copy link
Member

jonnitto commented Nov 9, 2023

Me neither

@markusguenther
Copy link
Member

The e2e test works in 8.2 and below, and 9.0. Also tried it locally and it works.

@markusguenther markusguenther merged commit fde80c9 into 8.3 Dec 16, 2023
8 of 9 checks passed
@markusguenther markusguenther deleted the bugfix/node-label-overflow branch December 16, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.3 Bug Label to mark the change as bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants