Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links between multi-site sites with ShortCut-Nodes are creating wrong redirects #58

Open
dlubitz opened this issue Oct 28, 2022 · 0 comments

Comments

@dlubitz
Copy link
Contributor

dlubitz commented Oct 28, 2022

When changing URLs linked between two sites in a multi-site setup, the redirecthandler creates wrong redirects.

How to reproduce

  1. Use a multi-site Setup with at least two websites and configured URLs
  2. Create a ShortCut node in Site A (site-a.com) with a Link to a some Url on Site B (site-b.com) (e.g https://site-b.com/link.html)
  3. Publish
  4. Change the Link of the shortcut node in Site A to some different URL on Site B (e.g https://site-b.com/new-link.html)
  5. Publish

What is the behavior

The redirecthandler creates a redirect entry for the Domain of Site A, but the Path of Site-B.
Moreover it tries to create multiple redirect entries, which lead to a "Duplicate entry" Exception on publish.

image

What is expected behavior

IMHO there shouldn't be redirects created at all, if the target of a shortcut has changed.

Solution

Maybe it is already a solution to exclude ShortCut-Nodes by default. But I'm afraid to miss a case where it might be useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant