BUGFIX: Create redirects with correct sourceUri
#7
Conversation
|
For a detailed bug description see: |
|
@gerhard-boden Thanks for this one, will test it asap, if I forgot, please ping me ;) When a PR fixes an issue, your can add "Fixes #9" in the footer of the first comment. |
|
@dfeyer Thanks for the hint! Will Github close the issue when this PR gets merged? I think we had a special feature for Jira that was supposed to do that. |
| @@ -98,8 +98,9 @@ public function createRedirectsForPublishedNode(NodeInterface $node, Workspace $ | |||
| $context = $this->contextFactory->create([ | |||
| 'workspaceName' => 'live', | |||
| 'invisibleContentShown' => true, | |||
| 'dimensions' => $node->getDimensions() | |||
| 'dimensions' => $node->getContext()->getDimensions() | |||
There was a problem hiding this comment.
This fix is absolutely correct because we want to preserve the context dimensions here, using the actual node dimension values means something totally different and could be wrong (e.g. "de", "fr" could be assigned to the node, but is not a valid list of dimension values in any preset).
However this is still not correct because we actually need to iterate over all dimension presets to do this for all node variants. I'd suggest to add this in a follow-up.
Create redirects with correct
sourceUriif a fallback dimension is present for the current node. Before this fix theuriSegmentfrom the fallback dimension was used for the current node and wrong redirects where created for the node and all it's children.Fixes: #9