Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't enable hit counter by default to prevent performance issues #19

Closed
Sebobo opened this issue May 22, 2019 · 0 comments
Closed

Don't enable hit counter by default to prevent performance issues #19

Sebobo opened this issue May 22, 2019 · 0 comments
Assignees
@Sebobo
Labels
enhancement
Projects
New Redirect Handler packages major r...

Comments

@Sebobo
Copy link
Member

Sebobo commented May 22, 2019

I assume that almost nobody who installs the packages knows that the feature switch is on by default.
This leads in my opinion to possible performance issues and in general unexpected write operations on the database.

Therefore I think it would make more sense to make it disabled by default and configurable on a per redirect basis.
See also neos/redirecthandler-ui#11
Sebobo added a commit that referenced this issue Jun 14, 2019
@Sebobo
!!! FEATURE: Disable hitCounter by default
7086476 
Having the hitcounter enabled causes additional
queries on the database on each redirect hit.
This might not be desired in projects.

Resolves: #19
@Sebobo Sebobo mentioned this issue Jun 14, 2019
Merged
@Sebobo Sebobo self-assigned this Jun 14, 2019
@Sebobo Sebobo closed this as completed in 6a86ce4 Aug 21, 2019
New Redirect Handler packages major release 2019 automation moved this from Review to Done Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sebobo Sebobo

Labels
enhancement
Projects
No open projects
New Redirect Handler packages major r...
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Sebobo