Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK: Adjust composer manifest #1

Merged
merged 4 commits into from
May 4, 2016
Merged

Conversation

kdambekalns
Copy link
Member

No description provided.

This allows to require 1.0@dev already,even though we did not branch yet.
Instead of just asking for any version of typo3/flow, limit to a more specific version.
This requires neos/redirecthandler-storageimplementation, which should be provided by
any, well, storage implementation for the redirecthandler.
"extra": {
"branch-alias": {
"dev-master": "1.0.x-dev"
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is to avoid having a 1.0 branch right? if so I don't think it will work since it will mean that the package can only be installed with Flow 3.2+ and not with dev-master.. that's why we have branches almost similar for the other packages..

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

>=3.2 would allow it to be installed with master as well allowing just one branch until actually necessary code wise.. maybe we should do the same for SEO and Analytics

that just means we need to always have a compatible version with the latest master

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also try to avoid that branch alias thing if possible.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kitsunet: may I ask why? personally would prefer just having one branch when the only difference is the composer requirement

@kdambekalns
Copy link
Member Author

@kdambekalns kdambekalns merged commit abeeadf into master May 4, 2016
@kdambekalns kdambekalns deleted the adjust-composer-manifest branch May 4, 2016 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants