feat: support native classes

neoskop · Mar 5, 2019 · 83c124f · 83c124f
1 parent 2426156
commit 83c124f
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 3 deletions.
diff --git a/src/reflection.spec.ts b/src/reflection.spec.ts
@@ -42,8 +42,8 @@ describe('Reflection', () => {
 
     describe('getAllClassMethods', () => {
         it('should return all class methods', () => {
-            expect(Reflection.getAllClassMethods(A)).to.be.eql([ 'methodA' ]);
-            expect(Reflection.getAllClassMethods(B)).to.be.eql([ 'methodB', 'methodA' ]);
+            expect(Reflection.getAllClassMethods(A)).to.be.eql([ 'methodA', 'toString', 'valueOf' ]);
+            expect(Reflection.getAllClassMethods(B)).to.be.eql([ 'methodB', 'methodA', 'toString', 'valueOf' ]);
         });
     });
 

diff --git a/src/reflection.ts b/src/reflection.ts
@@ -1,6 +1,18 @@
 import { Type } from '@angular/core';
 import { unique } from './utils';
 
+export const REFLECTION_PROPERTY_BLACKLIST = new Set([
+    '__defineGetter__',
+    '__defineSetter__',
+    'hasOwnProperty',
+    '__lookupGetter__',
+    '__lookupSetter__',
+    'isPrototypeOf',
+    'propertyIsEnumerable',
+    '__proto__',
+    'toLocaleString'
+]);
+
 /**
  * @hidden
  */
@@ -20,7 +32,7 @@ export class Reflection {
     static getOwnClassMethods(cls : Type<any>) : string[] {
         const methods : string[] = [];
 
-        for(const method of Object.keys(cls.prototype)) {
+        for(const method of Object.keys(Object.getOwnPropertyDescriptors(cls.prototype)).filter(key => !REFLECTION_PROPERTY_BLACKLIST.has(key))) {
             if('constructor' === method) continue;
             methods.push(method);
         }