Skip to content
This repository has been archived by the owner on Sep 13, 2023. It is now read-only.

feat: change logger from zerolog to zap #320

Merged
merged 2 commits into from
Feb 19, 2022
Merged

feat: change logger from zerolog to zap #320

merged 2 commits into from
Feb 19, 2022

Conversation

sashamelentyev
Copy link
Contributor

✔️ Checklist:

  • Have only one commit (if not, squash them into one commit)
  • Tests for the changes have been added (for features / bug fixes / refactoring)

@sashamelentyev sashamelentyev linked an issue Feb 19, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Feb 19, 2022

Codecov Report

Merging #320 (6bcbed8) into main (02fc272) will decrease coverage by 1.99%.
The diff coverage is 60.34%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #320      +/-   ##
==========================================
- Coverage   70.54%   68.54%   -2.00%     
==========================================
  Files          11       11              
  Lines         499      531      +32     
==========================================
+ Hits          352      364      +12     
- Misses        138      158      +20     
  Partials        9        9              
Impacted Files Coverage Δ
internal/server/handler.go 21.31% <0.00%> (ø)
internal/server/server.go 22.22% <50.00%> (ø)
internal/logger/logger.go 54.54% <52.38%> (-45.46%) ⬇️
internal/middleware/logging.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b870cd5...6bcbed8. Read the comment docs.

@sashamelentyev sashamelentyev merged commit 0d98537 into main Feb 19, 2022
@sashamelentyev sashamelentyev deleted the feat/logger branch February 19, 2022 08:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change logger from zerolog to zap
1 participant