Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Classic Era #24

Merged
merged 3 commits into from Jan 17, 2024
Merged

Fix Classic Era #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
09c3c3b
Fix classic era
tstirrat Oct 6, 2023
ce6e00d
bump toc
tstirrat Oct 6, 2023
aab9d0e
Better fix, edit mod:GetDifficultyInfo
tstirrat Oct 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion MagicMarker.lua
View file
Open in desktop
Expand Up @@ -198,7 +198,10 @@ function mod:GetDifficultyInfo()
local _,instype, diffid, diffname = GetInstanceInfo()
if instype ~= "none" and diffid and diffid > 0 then
local name, _, heroic = GetDifficultyInfo(diffid)
return diffid, name, heroic
-- Classic Era has GetDifficultyInfo but it returns nothing
if name then
return diffid, name, heroic
end
end
end
return 0, "Normal", false
Expand Down
2 changes: 1 addition & 1 deletion MagicMarker.toc
View file
Open in desktop
@@ -1,5 +1,5 @@
## Interface: 100002
## Interface-Classic: 11403
## Interface-Classic: 11404
## Interface-BCC: 20504
## Interface-Wrath: 30400
## X-Curse-Project-ID: 14363
Expand Down