Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hex colors not supported in 1.2draft #3

Closed
neotsn opened this issue Apr 29, 2020 · 1 comment
Closed

Hex colors not supported in 1.2draft #3

neotsn opened this issue Apr 29, 2020 · 1 comment
Assignees
@neotsn
Labels
bug Something isn't working

Comments

@neotsn
Copy link
Owner

neotsn commented Apr 29, 2020

Revert them back to rgba
@neotsn neotsn added the bug Something isn't working label Apr 29, 2020
@neotsn neotsn self-assigned this Apr 29, 2020
neotsn added a commit that referenced this issue Apr 29, 2020
@neotsn
Work for #3 "Hex colors not supported in 1.2draft"
8510421 
- Change set & render methods to use rgb instead of hex

Signed-off-by: neotsn neotsn <neotsn@gmail.com>
@neotsn
Copy link
Owner Author

neotsn commented Apr 29, 2020

Replaced the hex property with r, g, b properties, and updated the method to take 4 parameters instead of 2.

@neotsn neotsn closed this as completed Apr 29, 2020
@neotsn neotsn mentioned this issue Apr 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@neotsn neotsn

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@neotsn