New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade neo4j java driver to version 4 #140
Upgrade neo4j java driver to version 4 #140
Conversation
Looking forward to this |
97c91cf
to
f2ee6cb
Compare
f2ee6cb
to
9e3cc12
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BalmungSan looks good to me! 🚀 I see that this brings some incompatibilities with the old driver - do you think we need to release it with a new versioning schema (perhaps, bump the major version)?
And just one minor thing that we can address at any point the future - add some info about TransactionConfig
to the doc. But it's really minor, so we can merge this PR whenever you're ready.
@dimafeng I added the
Yeah, this should be a major release... however, I still do think we are ready to release the Anyways, I will proceed to merge this as well as the pending upgrade dependencies PRs (well, as soon as the GDS library officially publishes its |
Fixes #58
TODO list:
TransactionConfig
).I am still missing this:
But I believe that is work for another PR.
This is ready for review.