Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade neo4j java driver to version 4 #140

Merged
merged 10 commits into from Jul 9, 2020

Conversation

BalmungSan
Copy link
Contributor

@BalmungSan BalmungSan commented Jun 4, 2020

Fixes #58

TODO list:

  • Upgrade the driver and the docker container.
  • Fix compilation errors.
  • Fix tests.
  • Fix docs.
  • Cover all the new API (missing TransactionConfig).

I am still missing this:

  • Provide wrappers for the new Rx module.

But I believe that is work for another PR.
This is ready for review.

@BalmungSan BalmungSan requested a review from dimafeng June 4, 2020 22:56
@PhilAndrew
Copy link

Looking forward to this

@BalmungSan BalmungSan marked this pull request as ready for review June 21, 2020 17:57
@BalmungSan BalmungSan changed the title WIP: Upgrade neo4j java driver to version 4 Upgrade neo4j java driver to version 4 Jun 21, 2020
Copy link
Contributor

@dimafeng dimafeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BalmungSan looks good to me! 🚀 I see that this brings some incompatibilities with the old driver - do you think we need to release it with a new versioning schema (perhaps, bump the major version)?

And just one minor thing that we can address at any point the future - add some info about TransactionConfig to the doc. But it's really minor, so we can merge this PR whenever you're ready.

@BalmungSan
Copy link
Contributor Author

BalmungSan commented Jun 25, 2020

@dimafeng I added the TransactionConfig docs!

I see that this brings some incompatibilities with the old driver - do you think we need to release it with a new versioning schema.

Yeah, this should be a major release... however, I still do think we are ready to release the 1.0.0 version (at least not until the concurrency issues with Session are resolved #44).
So, I believe we should just release version 0.14.0. BTW, I just added a compatibility matrix to the docs.

Anyways, I will proceed to merge this as well as the pending upgrade dependencies PRs (well, as soon as the GDS library officially publishes its 1.3.0 version) so everything is ready for you to make the new release.

@BalmungSan BalmungSan merged commit 34fe223 into neotypes:master Jul 9, 2020
@BalmungSan BalmungSan deleted the upgrade-neo4j-java-driver branch July 9, 2020 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to Neo4j 4
3 participants