Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding the enumeratum module #291

Merged
merged 8 commits into from Apr 2, 2021
Merged

Adding the enumeratum module #291

merged 8 commits into from Apr 2, 2021

Conversation

BalmungSan
Copy link
Contributor

@BalmungSan BalmungSan commented Mar 25, 2021 •
edited

Fixes #237

  • Spec.
  • KeyMapper.
  • Implementation.
  • Docs.

@BalmungSan BalmungSan force-pushed the add-enumeratum branch 2 times, most recently from 7a4f3cd to acb53ae Compare March 25, 2021 22:55
@BalmungSan BalmungSan marked this pull request as ready for review March 26, 2021 23:32
@BalmungSan BalmungSan changed the title WIP Adding the enumeratum module Adding the enumeratum module Mar 28, 2021
dimafeng
dimafeng approved these changes Apr 2, 2021
View reviewed changes
Copy link
Contributor

@dimafeng dimafeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀 Would you like me to merge this one?

@BalmungSan BalmungSan merged commit 0c2e416 into neotypes:master Apr 2, 2021
@BalmungSan BalmungSan deleted the add-enumeratum branch April 2, 2021 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimafeng dimafeng dimafeng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support to Enumeratum
2 participants
@BalmungSan @dimafeng