case class mapper for maps

[geoffjohn11]

closes #26

[geoffjohn11]

The other use case of Tuple to Map isn't yet complete, but map projection to case class had a bit less to it. Two test cases are still commented out in MapSessionSpec. Any thoughts on this?

[BalmungSan]

Hi @geoffjohn11 Thanks for this!!

---

Could you make sure that you enable the "allow changes from maintainers" option in this PR, I would like to make a simple style change and ensure that collectMapFields is tail-recursive before merging.

[geoffjohn11]

Hi @geoffjohn11 Thanks for this!!

Could you make sure that you enable the "allow changes from maintainers" option in this PR, I would like to make a simple style change and ensure that collectMapFields is tail-recursive before merging.

That option is checked, so you should be able to make edits.

collectMapFields is not tail-recursive, so the annotation will cause a compilation failure, but I can take a look at making it tailrec.

[BalmungSan]

@geoffjohn11 I just remembered that Neo4j doesn't support nested maps, thus your recursive step wasn't necessary.

When I removed that, I discovered that an Entity is basically a Map, so we could reuse our old logic (with some minor tweaks).

So, in the end, we didn't need to do anything 😆
However, if it hadn't been for this PR we probably would never notice that.
Thank you very much for your interest in the project 👍

[geoffjohn11]

@geoffjohn11 I just remembered that Neo4j doesn't support nested maps, thus your recursive step wasn't necessary.

When I removed that, I discovered that an Entity is basically a Map, so we could reuse our old logic (with some minor tweaks).

So, in the end, we didn't need to do anything
However, if it hadn't been for this PR we probably would never notice that.
Thank you very much for your interest in the project

Interesting! Thanks for your help. I'll try to get the two other test in MapSessionSpec working.