Skip to content

Commit

Permalink
Use .dmg files to distribute for macOS (#549)
Browse files Browse the repository at this point in the history
This is the standard way to distribute applications for macOS.
It also avoids relying on GitHub to preserve file permissions (particularly +x) when zipping files.
Fixes #466
  • Loading branch information
Benjamin-Davies committed Apr 12, 2021
1 parent 6e2f955 commit 63d38fc
Showing 1 changed file with 7 additions and 2 deletions.
9 changes: 7 additions & 2 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -79,10 +79,15 @@ jobs:
mv MoltenVK_icd.json ./Resources/vulkan/icd.d/
install_name_tool -add_rpath "@executable_path/../Frameworks" ./MacOS/neovide
- name: Create .dmg file
run: |
hdiutil create Neovide-uncompressed.dmg -volname "Neovide" -srcfolder target/release/bundle/osx
hdiutil convert Neovide-uncompressed.dmg -format UDZO -o Neovide.dmg
- uses: actions/upload-artifact@v1
with:
name: Neovide.app
path: ./target/release/bundle/osx
name: Neovide.dmg
path: ./Neovide.dmg

This comment has been minimized.

Copy link
@Kethku

Kethku Apr 22, 2021

Member

Maybe I'm confused, but I don't get it...

This comment has been minimized.

Copy link
@j4qfrost

j4qfrost Apr 22, 2021

Contributor

Definitely a bot. Profile is empty.

This comment has been minimized.

Copy link
@Kethku

Kethku Apr 22, 2021

Member

lol ty


build-linux:

Expand Down

0 comments on commit 63d38fc

Please sign in to comment.