Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove unncessary dirs in linux artifact #1386

Merged
merged 1 commit into from Jul 8, 2022

Conversation

kskarthik
Copy link
Contributor

@kskarthik kskarthik commented Jul 5, 2022

Problem

The linux archive ships with un-necessary dir's,

kar@earth:~$ tar -tf Downloads/neovide.tar.gz
./target/release/neovide

Solution

This patch removes them & archives just the binary

What kind of change does this PR introduce?

  • Fix

Did this PR introduce a breaking change?

  • No

The linux archive ships with un-necessary dir's, This patch removes them & archive just the binary
@kskarthik
Copy link
Contributor Author

@Kethku please review & merge this patch :)

@MultisampledNight
Copy link
Contributor

Looks good to me, thank you! I'm wondering whether the cd has any forward effect outside of the step though.

@MultisampledNight
Copy link
Contributor

Okay, it's not, so your full path specification works just fine. Thanks again!

@MultisampledNight MultisampledNight merged commit 2a374ad into neovide:main Jul 8, 2022
@kskarthik
Copy link
Contributor Author

@MultisampledNight happy to know that worked! 🎉

@kskarthik kskarthik deleted the patch-1 branch July 9, 2022 05:01
@kskarthik
Copy link
Contributor Author

@MultisampledNight currenly, only linux x86_64 binaries are built? Then it would be nice to rename archive with neovide-linux-$VERSION-$ARCH.tar.gz

@MultisampledNight
Copy link
Contributor

MultisampledNight commented Jul 10, 2022

Hm, 32-bit computers have barely any presence anymore, distros like Arch dropped support several years ago. The Windows archive doesn't really need the architecture either. Is there any specific reason you need the architecture in the filename? Or is it for pure convenience?

@kskarthik
Copy link
Contributor Author

@MultisampledNight just for convenience sake & a visual clue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants