Clipboard: Read channel id from nvim variable #1411
Conversation
[Clipboard providers are only loaded once by Neovim](neovim/neovim#8017), causing the previous code to use an obsolete channel id when reconnecting to a remote nvim instance.
| .replace('\n', "") // make one-liner, because multiline is not accepted (?) | ||
| .replace("neovide_channel", &neovide_channel.to_string()); | ||
| nvim.command(&custom_clipboard).await.ok(); | ||
| nvim.set_var("neovide_channel_id", Value::from(neovide_channel)) |
There was a problem hiding this comment.
If you set this var, shouldn't it be removed after executing the Lua code? Else someone could stumble across this and potentially rely on an outdated value.
There was a problem hiding this comment.
Unfortunately, that won't work, since the variable is read whenever the + and * registers are accessed. Reading the channel from a variable allows us to use the same clipboard provider across multiple UI sessions.
Else someone could stumble across this and potentially rely on an outdated value.
A session has only one channel id in its lifetime, and the variable is updated whenever Neovide attaches to nvim, so this shouldn't be too much of an issue. (Unless the user starts multiple overlapping sessions, but we don't seem to support that at all).
While I'm generally strongly in favor of data encapsulation, having the channel id in a global variable makes debugging of channel issues a lot easier.
An alternative approach is to forcibly reload the clipboard provider whenever Neovide attaches to nvim. We might need something like that in order to fix #1331. This could also make it possible to mix different UI clients without breaking the clipboard. The drawbacks are that this seems like a hack, and it might break things for users who rely on the clipboard provider being loaded only once. I think the best approach is to make forcible reloading optional (can be disabled by setting a variable) and combining it with the present solution.
There was a problem hiding this comment.
That's a good idea, thanks for the extended explanation!
|
Thank you! |
Clipboard providers are only loaded once by Neovim, causing the previous code to use an obsolete channel id when reconnecting to a remote nvim instance.
Fixes #1329.
What kind of change does this PR introduce?
Did this PR introduce a breaking change?
A breaking change includes anything that breaks backwards compatibility either at compile or run time.
I hope not.