Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable confirm quit by default #1440

Merged
merged 6 commits into from Aug 9, 2022
Merged

Conversation

dineshKumar777
Copy link
Collaborator

What kind of change does this PR introduce?

  • Refactor

Did this PR introduce a breaking change?

  • No

This is the default behaviour in nvim-qt. So enabled it by default.
#1247 - original PR with flag.

@MultisampledNight
Copy link
Contributor

Thank you! While I understand the motivation, I think it's a bit overkill to disallow non-confirmed exit. Even browsers and large IDEs allow ignoring the confirm popup if they really want to.

So I think it'd be preferable to just change the default of the variable to 1 instead of 0.

@dineshKumar777
Copy link
Collaborator Author

dineshKumar777 commented Jul 31, 2022

@MultisampledNight
Most IDE and Editor(vscode, visual studio, jetbrains IDE) which i used doesn't support non-confirmed exit. can you give any other IDE which supports this!!
Sublime is the only editor which i know supports non-confirmed exit but that will preserve my changes on next launch.

but here we are losing data when we accidentally close the window. also this is the default behaviour with nvim-qt too. All i am looking for is better defaults.

EDIT: to be sure, this confirm quit happens only when you have unsaved changes. Otherwise it will exit as normal

@MultisampledNight
Copy link
Contributor

PyCharm community allows doing so, under Appearance & Behavior > System Settings and then Confirm before exiting the IDE. I didn't mean to disable the behavior at all, just to keep it configurable in case a user (such as me) doesn't want that, I probably misworded my first comment. But at the moment the PR is enforcing the behavior, ignoring the value of g:neovide_confirm_quit.

@dineshKumar777
Copy link
Collaborator Author

Now its configurable.
Confirm_quit is enabled by default for any unsaved changes.
to disable, we can disable by :let g:neovide_confirm_quit=0 or v:false

@MultisampledNight
Copy link
Contributor

(rebased to resolve the merge conflict)

@MultisampledNight MultisampledNight merged commit 8717391 into neovide:main Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants