Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support background color on MacOS #1459

Merged
merged 7 commits into from Aug 6, 2022
Merged

Conversation

Matts966
Copy link
Contributor

@Matts966 Matts966 commented Aug 5, 2022

What kind of change does this PR introduce?

  • Feature
  • Documentation

Did this PR introduce a breaking change?

A breaking change includes anything that breaks backwards compatibility either at compile or run time.

  • No

Support colorized title bar by g:neovide_background_color for macOS, discussed in #1298

BackgroundColor

@Matts966
Copy link
Contributor Author

Matts966 commented Aug 5, 2022

2022-08-06.7.59.35.mov

@Matts966 Matts966 mentioned this pull request Aug 6, 2022
Copy link
Contributor

@MultisampledNight MultisampledNight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Three small things I'd like to have addressed before driving this thing home.

src/window/mod.rs Outdated Show resolved Hide resolved
website/docs/configuration.md Outdated Show resolved Hide resolved
src/settings/draw_background.rs Outdated Show resolved Hide resolved
@Matts966
Copy link
Contributor Author

Matts966 commented Aug 6, 2022

@MultisampledNight
Thank you for your nice review :)
I fixed your points and confirmed cargo fmt --check exit with code 0.

@MultisampledNight
Copy link
Contributor

Alright then, I think this should be ready to go. Thank you again!

One small thing for the future in case you contribute again somewhere (also applies not only to this repo): Consider making a branch on your fork for every PR you make, and don't directly commit to your fork's main. This avoids some tricky local git scenarios where technically both origin and your remote are checked out, but both branches are named main.

@MultisampledNight MultisampledNight merged commit 1be184e into neovide:main Aug 6, 2022
@Matts966
Copy link
Contributor Author

Matts966 commented Aug 6, 2022

@MultisampledNight
Thank you for your kind fix 🥹

@zhaozg
Copy link

zhaozg commented Aug 6, 2022

I got error on MacOS X86_64

[I] ✘101 ➜ PYTHON=python3 cargo build --release
   Compiling neovide v0.9.0 (/Users/zhaozg/work/extra/vide)
error[E0433]: failed to resolve: use of undeclared crate or module `cocoa`
 --> src/window/draw_background.rs:4:5
  |
4 | use cocoa::appkit::{NSColor, NSWindow};
  |     ^^^^^ use of undeclared crate or module `cocoa`

error[E0433]: failed to resolve: use of undeclared crate or module `cocoa`
 --> src/window/draw_background.rs:5:5
  |
5 | use cocoa::base::{id, nil};
  |     ^^^^^ use of undeclared crate or module `cocoa`

error[E0433]: failed to resolve: use of undeclared crate or module `objc`
 --> src/window/draw_background.rs:8:5
  |
8 | use objc::{rc::autoreleasepool, runtime::YES};
  |     ^^^^ use of undeclared crate or module `objc`

For more information about this error, try `rustc --explain E0433`.
error: could not compile `neovide` due to 3 previous errors

@MultisampledNight
Copy link
Contributor

Oh welp, I'll try to take care of it.

@MultisampledNight
Copy link
Contributor

I think I got it. Could you try again?

@zhaozg
Copy link

zhaozg commented Aug 7, 2022

I think I got it. Could you try again?

It's works, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants