New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support background color on MacOS #1459
Conversation
2022-08-06.7.59.35.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Three small things I'd like to have addressed before driving this thing home.
@MultisampledNight |
Hopefully makes the CI happy.
Alright then, I think this should be ready to go. Thank you again! One small thing for the future in case you contribute again somewhere (also applies not only to this repo): Consider making a branch on your fork for every PR you make, and don't directly commit to your fork's main. This avoids some tricky local git scenarios where technically both origin and your remote are checked out, but both branches are named |
@MultisampledNight |
I got error on MacOS X86_64
|
Oh welp, I'll try to take care of it. |
I think I got it. Could you try again? |
It's works, thank you. |
What kind of change does this PR introduce?
Did this PR introduce a breaking change?
A breaking change includes anything that breaks backwards compatibility either at compile or run time.
Support colorized title bar by
g:neovide_background_color
for macOS, discussed in #1298