Fix #1475 #1483
Merged
Fix #1475 #1483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, CTRL+SHIFT keystrokes registered as like so: CTRL+SHIFT+p = <C-P> instead of <C-S-p> or <C-S-P> CTRL+SHIFT+x = <C-X> instead of <C-S-x> or <C-S-X> ... So different keymaps couldn't be assigned to CTRL+x and CTRL+SHIFT+x because nvim assumes it is the same mapping. Now, CTRL+SHIFT+x is interpreted as <C-S-X>, so different mappings can be assigned to CTRL+x and CTRL+SHIFT+x.
|
Thank you! Even though this is technically a breaking change, since someone could've wanted to map Ctrl + Shift + ... and mapped it to |
This was referenced Aug 22, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, CTRL+SHIFT keystrokes registered as like so:
CTRL+SHIFT+p = <C-P> instead of <C-S-p> or <C-S-P>
CTRL+SHIFT+x = <C-X> instead of <C-S-x> or <C-S-X>
...
So different keymaps couldn't be assigned to CTRL+x and CTRL+SHIFT+x
because nvim assumes it is the same mapping.
Now, CTRL+SHIFT+x is interpreted as <C-S-X>, so different mappings can
be assigned to CTRL+x and CTRL+SHIFT+x.
What kind of change does this PR introduce?
Did this PR introduce a breaking change?
A breaking change includes anything that breaks backwards compatibility either at compile or run time.