Save backtrace to file on panic #1681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Awesome, thank you! 🎉
I forgot to tell you this, and it doesn't seem like it's stated anywhere visible, so here I go: Should you contribute here or somewhere else, please consider creating another branch than main for your changes, and PR from that branch to this main. This makes local testing setups less messy, for a lengthier explanation see #1468 (comment).
|
Looks good to me! I'd leave it bit-rot a day or two, then get it in. |
|
Choooooo chooooooooooo! Thank you! |
TENX-S
pushed a commit
to TENX-S/neovide
that referenced
this pull request
Jan 24, 2023
Co-authored-by: MultisampledNight <contact@multisamplednight.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Did this PR introduce a breaking change?
A breaking change includes anything that breaks backwards compatibility either at compile or run time.
I added a panic hook that appends the backtrace to a log file in the current directory so that there is some clue as to what happened when neovide crashes.
It works by attaching a panic hook at the beginning of
main(). The original main function has been moved toprotected_main(). I moved it here for now as I was not sure how to integrate the hook intomain()'s documentation.