Resolve clippy warnings #1759
Merged
Resolve clippy warnings #1759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! |
MultisampledNight
added a commit
that referenced
this pull request
Feb 9, 2023
Expands #1759. I don't know why the PR didn't contain everything, but here we go.
|
Thank you! I should have also compared with the CI warnings and make sure my clippy is up to date. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Fixes all the fluff generated by Clippy. Since there are so few warnings, imho it is best to just fix them, regardless of whether they are all important to neovide.
This will allow to extend the workflows to get more expressive reporting of clippy warnings and thus better detect shortcomings and improve overall code quality.
Did this PR introduce a breaking change?
A breaking change includes anything that breaks backwards compatibility either at compile or run time.