Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support mouse hover (emit mouse move event) #1766

Merged
merged 4 commits into from Apr 8, 2023

Conversation

ryo33
Copy link
Contributor

@ryo33 ryo33 commented Feb 10, 2023

Calls nvim_input_mouse() with button = "move".
Currently, it always emits the events, but IMO it should not emit the events if "mousemoveevent" option is not enabled. How should we achieve this behavior?

  • Emit the event
  • Do not emit the event when "mousemoveevent" option is disabled
  • Rerender if mouse moved even if not dragged (ignore self.dragging.is_some() if "mousemoveevent" option is enabled)

What kind of change does this PR introduce?

  • Feature

Did this PR introduce a breaking change?

  • Yes, emits new event

@Kethku
Copy link
Member

Kethku commented Apr 8, 2023

I'm going to merge this as the other remaining todos dont seem too important.

@Kethku Kethku merged commit 5b4ae91 into neovide:main Apr 8, 2023
2 checks passed
falcucci pushed a commit to falcucci/neovide that referenced this pull request Apr 19, 2023
* Emit mouse move event

* Emits mouse move event only when moved

* Fix

* removed the dummy text in favor of an empty string

---------

Co-authored-by: Kaylee Simmons <kay@the-simmons.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants