New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update configuration.md doc to reflect reality #1772
Conversation
#1211 (comment) the colon is required for the parser to pick up the option
I think a better recommendation would be to suggest doing vim.o.guifont = "Source Code Pro:h14" |
@ad-chaos i like your suggestion. On the other hand, i think format And we should fix our code to accept this. |
Hmm, in that case you should take that to neovim since they control |
impl FontOptions {
pub fn parse(guifont_setting: &str) -> FontOptions {
let mut font_options = FontOptions::default();
let mut parts = guifont_setting.split(':').filter(|part| !part.is_empty()); That's our code, we just expect |
If you run something like lua vim.opt.guifont = {"Source Code Pro", "h14"}
se guifont? You'll see that the way that table is parsed into We could add our own bit of logic to check when it is an option and when it is a font, but what if someone wants to use a font named |
Help me understand, please: My understanding of the documentation:
is that "options apply to all fonts" meaning "all fonts listed in the same string through a comma". It kind of makes sense, I may have a group of fonts which bear similar characteristics (like not having antialias recommended) and I list such fonts together in one string and with the same options. But if these fonts are not present/supported I fall back to another set of fonts with another set of options. "Cross-pollination" of options doesn't make any sense to me. Or I'm just royally misunderstand something. Edit: font in question is https://github.com/kika/fixedsys and it requires anti-alias off to look genuinely old as I am. |
So @MultisampledNight cleared that up on discord. Fonts are a comma separated list of fallbacks followed by a colon with options that apply to all the fallbacks. Edit: |
@ad-chaos so the behavior is "even if If yes, super confusing I'd say. Why list then. |
well, its not a list, its a string all along. |
Use `vim.o`, don't use magic
PR updated |
Alright, thank you! |
#1211 (comment)
the colon is required for the parser to pick up the option
What kind of change does this PR introduce?
Did this PR introduce a breaking change?