Use new scroll delta field in viewport event for smooth scrolling #1827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
falcucci
pushed a commit
to falcucci/neovide
that referenced
this pull request
Apr 19, 2023
…ovide#1827) * Use new scroll delta event for smooth scrolling * Fix clippy warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Replaces the old viewport handling with the new scroll_delta event so that we can get actually correct smooth scrolling.
Did this PR introduce a breaking change?
Yes, it disables the smooth scrolling for viewport events which do not have the scroll_delta field. This way we only do it if we know it is correct.