Bridge unix sockets and named pipes #1828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes TxWrapper a misnomer. I'll rename it in a follow-up commit to facilitate easier reviewing.
Hopefully this makes the connection logic easier to understand.
Closed
falcucci
pushed a commit
to falcucci/neovide
that referenced
this pull request
Apr 19, 2023
* Use tokio compat_write as TxWrapper. This makes TxWrapper a misnomer. I'll rename it in a follow-up commit to facilitate easier reviewing. * Rename TxWrapper -> NeovimWriter. * Bridge: Add support for Unix sockets and named pipes. * Document the `--server` flag. * Add --server to command line reference. * connection.rs: Clean up parameter and return types. * Remove unused file. * Bridge: Introduce NeovimSession and NeovimInstance abstractions. Hopefully this makes the connection logic easier to understand. * Bridge: Rename connection.rs -> session.rs. * Replace core::result::Result with std::result::Result. * Remove await on non future for windows builds * Fixup named pipe functionality and update feature.md docs * Fix clippy warning * Fix test build error --------- Co-authored-by: khjorth <13965958+khjorth@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes up #1591 on windows
This PR adds support for connecting to Neovim instances over Unix domain sockets and named pipes. It resolves #1412.
Named pipes are a Windows feature, and since I don't run Windows, I haven't been able to test that part.
I have added
--serveras a new command line argument that covers all connections to existing Neovim instances, because--remote-tcpas the official way to connect to Unix sockets and named pipesremoteas part of the name--serverargument, so it should be familiar for Neovim users:h serverstartWhat kind of change does this PR introduce?
Did this PR introduce a breaking change?
A breaking change includes anything that breaks backwards compatibility either at compile or run time.
--remote-tcpargument is still supported as an alias for--server