Fix opening from Finder in macOS #1832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Omg thank you I've been going crazy trying to figure this out |
|
Awesome! Thank you so much for the fix <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
A fix for a bug introduced in #1758 where opening Neovide from Finder (i.e. directly running the .app) when using the fish shell as your $SHELL fails. Running
neovidefrom a terminal works fine.Previously (in 0.10.3), Neovide would always run
$SHELL -lc "which nvim"on macOS to find thenvimbinary. After #1758, it now runs$SHELL -c -l "which nvim"only if the TERM environment variable is not set.bashandshdo not care about the order of the-cand-lflags, butfishdoes (I haven't tested other shells). This fix simply reorders those flags, fixing the issue.Did this PR introduce a breaking change?
No