fix: Fix deadkey sequences ending with space #1930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A dead key followed by space will usually result in the character itself. However, Neovide resolved this wrongly, and always treated space as a special key, so the sequence was resolved as space instead.
fredizzimo
force-pushed
the
fsundvik/fix-deadkeys
branch
from
2afcd2d
to
d08c500
Compare
|
This fix is for some reason not working in X11, but in Wayland it does. I will try to figure out what's wrong. |
|
The problem on X11 was just a merge mistake in the "Smooth rendering" branch. The current version of Winit requires IME to be enabled on X11 for dead keys to work, but the "Smooth rendering" branch disables it by default. |
Merged
src/window/keyboard_manager.rs
Outdated
| match key { | ||
| Key::Backspace => Some("BS"), | ||
| Key::Space => Some("Space"), | ||
| Key::Space => { | ||
| // Space can finish a dead key sequence, so only threat space as a special key when |
There was a problem hiding this comment.
Typo
Suggested change
| // Space can finish a dead key sequence, so only threat space as a special key when | |
| // Space can finish a dead key sequence, so only treat space as a special key when |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
A dead key followed by space will usually result in the character itself. However, Neovide resolved this wrongly, and always treated space as a special key, so the sequence was resolved as space instead.
Did this PR introduce a breaking change?