Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS configuration options for using only the left or right alt key … #1979

Closed
wants to merge 1 commit into from

Conversation

apettel
Copy link

@apettel apettel commented Aug 15, 2023

…as meta

What kind of change does this PR introduce?

  • Feature

I'm using the EurKEY Keyboard Layout. To access certain characters (e.g. ä, ö, ü, ß) I need the alt key. But I also need the alt key as meta key for certain terminal applications.
I configured the right alt key in my terminal program to switch the characters in the EurKEY-Layout and the left alt key is used as meta key. I created a patch for neovide to allow the separate configuration of the right and the left alt key (branch: macos-left-right-alt-meta).

Did this PR introduce a breaking change?

  • No

@fredizzimo
Copy link
Member

Thanks, but this should be implemented using the native Winit OptionAsAlt rust-windowing/winit#2887

The only reason why it wasn't implemented like that before is that it came when this was almost finished #1899. And because I don't have a mac to test on, I did not want to risk anything.

If you implement it using that, I think all, at least almost all the macOS specific stuff in keyboard_manager.rs can be removed.

@fredizzimo
Copy link
Member

This is the relevant issue for this PR #1877

And it might also fix this issue (that needs to be tested)
#1866

@fredizzimo fredizzimo linked an issue Aug 15, 2023 that may be closed by this pull request
@uloco
Copy link

uloco commented Aug 18, 2023

omg i need this so badly, typing on a german layout makes using neovide impossible right now without this. hope this gets merged soon. thank you!

the thing is, you need to be able to set it separately in neovide config. because it is not configured on a system level. option + characters is always a character, not a modifier if it is an input field and not a global shortcut. i also set this config in iTerm for example where you can specify each option key separately.

These are my settings in iTerm to make it clearer:
image

Copy link
Member

@fredizzimo fredizzimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm making it more explicit that this won't be approved until it's re-implemented with OptionAsAlt as described in the first message.

Note, that I'm very happy to see this being done and worked on and I don't see anything specifically wrong with this implementation. It's just that we don't want to maintain and duplicate work that's already done in Winit, and we also want to avoid special cases for different operating systems where possible.

@fredizzimo
Copy link
Member

An alternative implementation was done here

@fredizzimo fredizzimo closed this Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to map only the left option key to meta on macOS
3 participants