fix: Show intro message when the ui command msg_intro is received #1985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredizzimo
force-pushed
the
fsundvik/msg_intro
branch
from
96cd297
to
a27de28
Compare
fredizzimo
changed the title
MultisampledNight
changed the title
This only works on Neovim >=0.9.2, so on older versions the message is built like before. Also respect the shortmess I option and use Vim instead of lua for random to avoid polluting the global seed.
VimEnter can be called many times when using Lazy loading, which breaks the intro message.
fredizzimo
force-pushed
the
fsundvik/msg_intro
branch
from
a27de28
to
2349676
Compare
fredizzimo
changed the title
MultisampledNight
approved these changes
Aug 30, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
msg_introis now used to show the intro message, when it's available. That will happen once this Neovim PR is merged and released neovim/neovim#24764. Otherwise the message text it built manually like before, and showed usingVimEnterIn addition to this it fixes these two issues
shortmess+=I` option now worksdashboard-nvim. And most likely in some other situations that did not work previously. The issue was that the lazy loading ofpacker.nvim(and maybe lazy.nvim) withevent=VimEntercausesVimEnterto be called twice.It also changes the use of lua random to VIM random to avoid polluting the global lua random seed.
Did this PR introduce a breaking change?
A breaking change includes anything that breaks backwards compatibility either at compile or run time.