New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add drop shadow to floating windows #2028
Conversation
This PR is still waiting on a release from skia and agreement on the way to configure this behavior. Neovim does have a shadow border in it's list of existing borders, but in my opinion this effect works best when there aren't any added border characters. I'm personally inclined to merge this with a setting of some sort (even just a global setting for now to see how people like it) and then think about integrating with neovim directly after it settles, but its an open question. |
Fwiw skia-safe 0.67.0 is out, including the previously missing shadow flags. Only thing open now is the neovim integration. |
8867235
to
d254390
Compare
Btw, maybe we can use the same We're using sctk-adwaita, but it uses tiny-skia, which doesn't have |
Honestly I have no idea. I dont understand linux window compositing and dont use linux personally, so somebody would have to give it a try. My gut is that it wouldn't work as skia needs a canvas to draw onto, but thats only a guess |
This is about ready to merge. Only remaining issues are documentation of the new configuration settings and a fix for the failing macos build. I'm not sure whats up with the mac ci pipeline and am too tired to figure it out myself rn |
I think need to figure out the mac CI issues first, it seems like there's some problems with the ARM toolchain, even if the logs says that it's installed properly. As for the window shadows, I don't think we should give in on Gnome's agenda to refuse to implement the server side window decorations - https://wayland.app/protocols/xdg-decoration-unstable-v1 protocol and force every application to draw their own client-side decorations. At least not without using a common library, like I don't see any technical reason's why it can't be done there, it's just that none one have had the motivation to do the work until now, but just yesterday, there's a new draft PR up PolyMeilex/sctk-adwaita#43 Furthermore, the more complete adwaita library has moved under the Gnome organization here https://gitlab.gnome.org/World/Rust/libadwaita-rs. So maybe someone could convince winit to support that. |
Co-authored-by: multisn8 <contact@multisamplednight.com>
…ecified variables
f803b2f
to
62974e5
Compare
Adds drop shadows to floating windows to help differentiate them from the background.
Remaining Tasks:
What kind of change does this PR introduce?
Did this PR introduce a breaking change?