Added numpad support #2032
Merged
Added numpad support #2032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredizzimo
requested changes
Sep 17, 2023
fredizzimo
reviewed
Sep 17, 2023
fredizzimo
approved these changes
Sep 17, 2023
|
I have not yet tested this, but the code looks good. |
Closed
|
Re-requesting check due to a bug introduced by erroneously adding < and > signs within the special key formatting function |
fredizzimo
approved these changes
Sep 17, 2023
|
Thank you! I did not get the all the modifiers to work in combination with the keypad on Windows. But I think that's more of a problem with Winit not reporting it correctly, or even not supported by the operating system. |
hhirtz
added a commit
to hhirtz/neovide
that referenced
this pull request
Feb 2, 2024
Follow up of neovide#2032 See neovim docs [0] as well as winit's [1]. Please note that I don't have a numpad with kEqual and kComma keys, I could only test kPoint. [0] https://github.com/neovim/neovim/blob/1bf645918e94e7e8f770592484164f1ee303f24e/runtime/doc/intro.txt#L377-L379 [1] https://docs.rs/winit/0.29.10/winit/keyboard/enum.KeyCode.html#variant.NumpadComma
hhirtz
added a commit
to hhirtz/neovide
that referenced
this pull request
Feb 2, 2024
Follow up of neovide#2032 See neovim docs [0] as well as winit's [1]. [0] https://github.com/neovim/neovim/blob/1bf645918e94e7e8f770592484164f1ee303f24e/runtime/doc/intro.txt#L377-L379 [1] https://docs.rs/winit/0.29.10/winit/keyboard/enum.KeyCode.html#variant.NumpadComma
hhirtz
added a commit
to hhirtz/neovide
that referenced
this pull request
Feb 2, 2024
Follow up of neovide#2032 See neovim docs [0] as well as winit's [1]. [0] https://github.com/neovim/neovim/blob/1bf645918e94e7e8f770592484164f1ee303f24e/runtime/doc/intro.txt#L377-L379 [1] https://docs.rs/winit/0.29.10/winit/keyboard/enum.KeyCode.html#variant.NumpadComma
hhirtz
added a commit
to hhirtz/neovide
that referenced
this pull request
Feb 2, 2024
Follow up of neovide#2032 See neovim docs [0] as well as winit's [1]. [0] https://github.com/neovim/neovim/blob/1bf645918e94e7e8f770592484164f1ee303f24e/runtime/doc/intro.txt#L377-L379 [1] https://docs.rs/winit/0.29.10/winit/keyboard/enum.KeyCode.html#variant.NumpadComma
hhirtz
added a commit
to hhirtz/neovide
that referenced
this pull request
Feb 3, 2024
Follow up of neovide#2032 See neovim docs [0] as well as winit's [1]. [0] https://github.com/neovim/neovim/blob/1bf645918e94e7e8f770592484164f1ee303f24e/runtime/doc/intro.txt#L377-L379 [1] https://docs.rs/winit/0.29.10/winit/keyboard/enum.KeyCode.html#variant.NumpadComma
fredizzimo
pushed a commit
that referenced
this pull request
Feb 3, 2024
Follow up of #2032 See neovim docs [0] as well as winit's [1]. [0] https://github.com/neovim/neovim/blob/1bf645918e94e7e8f770592484164f1ee303f24e/runtime/doc/intro.txt#L377-L379 [1] https://docs.rs/winit/0.29.10/winit/keyboard/enum.KeyCode.html#variant.NumpadComma
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Did this PR introduce a breaking change?
A breaking change includes anything that breaks backwards compatibility either at compile or run time.