Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix mouse dragging #2082

Merged
merged 2 commits into from Oct 19, 2023
Merged

Conversation

fredizzimo
Copy link
Member

What kind of change does this PR introduce?

Fixes mouse dragging

Mouse move should not be sent when the mouse is dragged. It looks like Neovim can't deal with both events happen simultaneously.

This also fixes a clippy issue.

Did this PR introduce a breaking change?

A breaking change includes anything that breaks backwards compatibility either at compile or run time.

  • No

Mouse move should not be sent when dragging
@fredizzimo fredizzimo mentioned this pull request Oct 16, 2023
@fredizzimo fredizzimo linked an issue Oct 16, 2023 that may be closed by this pull request
@9mm
Copy link
Contributor

9mm commented Oct 16, 2023

Just tested on OSX works amazing

Out of curiosity, do you know what style token I would use to style the part UNDER the mouse?

Its hard to explain but if you click+drag, the actual cursor moves to the end of the word, but underneath the mouse it turns black. Im assuming becuase my theme isnt styling whatever that is called

@fredizzimo
Copy link
Member Author

@9mm, I don't think there are any https://neovim.io/doc/user/syntax.html#highlight-groups, so it might be a Neovim bug.

The cursor is displayed like normal at the end of the selection, and that is controlled by https://neovim.io/doc/user/options.html#'guicursor'. But I don't think it affects the fake cursor under the mouse pointer.

There's also a https://neovim.io/doc/user/options.html#'mouseshape' option, but that is currently not implemented, even if it's documented neovim/neovim#21458

@9mm
Copy link
Contributor

9mm commented Oct 16, 2023

Gotcha. Totally not a big deal just curious. Thanks, this highlighting bug will help me a lot. 99% of the times i have to use the mouse but other times I do need to do significant copying pasting into other things outside the editor which can be tedious

Thanks you so much 💯

@Kethku Kethku merged commit 85234dc into neovide:main Oct 19, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Double-click + Drag
3 participants