Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix macOS startup issues #2107

Merged
merged 3 commits into from Nov 8, 2023
Merged

fix: Fix macOS startup issues #2107

merged 3 commits into from Nov 8, 2023

Conversation

fredizzimo
Copy link
Member

@fredizzimo fredizzimo commented Nov 6, 2023 •
edited

What kind of change does this PR introduce?

  • Updates glutin to fix a regression in Glutin 0.31.0
  • Fixes race conditions in event_aggregator. The use of two different locks can cause issues if two threads are trying to get a non existing channel at the same time, since that was followed by both of them trying to create a new channel, while only one of them should do that.
  • Fixes Window creation fails #2097

Did this PR introduce a breaking change?

  • No

@fredizzimo fredizzimo marked this pull request as draft November 6, 2023 15:11
@fredizzimo fredizzimo mentioned this pull request Nov 6, 2023
Closed
@fredizzimo fredizzimo marked this pull request as ready for review November 6, 2023 15:38
@Kethku Kethku merged commit 7cf572e into neovide:main Nov 8, 2023
2 checks passed
@razvanazamfirei razvanazamfirei mentioned this pull request Dec 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Window creation fails
2 participants
@fredizzimo @Kethku