feat!: Add underline scale factor config #2116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…configuration to be a scale factor as per user request
MultisampledNight
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make automatic underline scaling the default and change the existing configuration to be a scale factor as per user request
Implements #1976
What kind of change does this PR introduce?
Did this PR introduce a breaking change?
Removed old underline_automatic_scaling config as it seems to work great and I haven't seen any requests for how to enable it. The scale factor feels like a better user facing config.
The new system also slightly adjusts where the aliasing starts so that its a clamp instead of an arbitrary cutoff