Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent empty window title #2126

Merged
merged 1 commit into from Nov 13, 2023
Merged

fix: prevent empty window title #2126

merged 1 commit into from Nov 13, 2023

Conversation

raggi
Copy link
Contributor

@raggi raggi commented Nov 12, 2023

If Neovim attempts to send an empty window title, it is now set to
Neovide instead, rather than the empty string.

This improves two user scenarios:

  • Users who utilize assistive technologies will now always observe a
    window title by default.
  • Users of window managers that rely on window titles will have improved
    integration.

The precipitating use case was using Komorebi, a tiling window manager
for Windows. Komorebi uses an empty window title as a strong signal that
the software is a hidden window, as this is a common convention on the
platform.

Updates #1553

@fredizzimo
Copy link
Member

I don't think this should be configurable, since the configuration can already be done with title and titlestring. But I think hardcoding it to Neovide when it's empty would be ok, that way the title can also be set immediately when the window is created and not at a later time when the configuration is read.

If Neovim attempts to send an empty window title, it is now set to
Neovide instead, rather than the empty string.

This improves two user scenarios:

- Users who utilize assistive technologies will now always observe a
  window title by default.
- Users of window managers that rely on window titles will have improved
  integration.

The precipitating use case was using Komorebi, a tiling window manager
for Windows. Komorebi uses an empty window title as a strong signal that
the software is a hidden window, as this is a common convention on the
platform.

Updates neovide#1553
@raggi raggi changed the title feat: add fallback window title setting fix: prevent empty window title Nov 13, 2023
@raggi
Copy link
Contributor Author

raggi commented Nov 13, 2023

I don't think this should be configurable, since the configuration can already be done with title and titlestring. But I think hardcoding it to Neovide when it's empty would be ok, that way the title can also be set immediately when the window is created and not at a later time when the configuration is read.

Done.

@Kethku
Copy link
Member

Kethku commented Nov 13, 2023

Thanks for the fix! I noticed a similar issue recently and hadn't tracked down what was going on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants