fix: Don't poll the event loop on Wayland to reduce the power usage #2149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disable most tracy features by default, but they can be enabled separately if needed.
fredizzimo
force-pushed
the
fsundvik/fix-wayland-idle
branch
2 times, most recently
from
cc78d74
to
ebd3465
Compare
fredizzimo
force-pushed
the
fsundvik/fix-wayland-idle
branch
from
ebd3465
to
22976fb
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
When the winit vsync is used, the event loop should never be polled, otherwise the CPU usage is just wasted. Winit will send the redraw request and wake the loop up when it's time to render anyway.
All other ways of doing vsync, just blocks inside the loop itself, so polling should be used there.
This also updates the tracy profiler to the latest version.
Did this PR introduce a breaking change?