fix!: Ignore window size when minimized #2153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that no zero size windows are created for example, which might be very hard or impossible to find on the desktop.
|
Hell yes. That bug around window size changing has been driving me up a wall. LGTM. Merge when ready |
Kethku
reviewed
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Some platforms report a zero window size when minimized, so ignore that when saving the window size and resizing the Neovide grid.
Also enforce a minimum and maximum window size when restoring a saved size. This ensures that a window with a zero size is not displayed.
Fixes
Fixes partially:
It also fixes the annoying issue that the window layout changes when the window is minimized and then restored again.
Did this PR introduce a breaking change?
A breaking change includes anything that breaks backwards compatibility either at compile or run time.