Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: NEOVIDE_FORK environment variable #2189

Merged
merged 7 commits into from Dec 23, 2023
Merged

feat: NEOVIDE_FORK environment variable #2189

merged 7 commits into from Dec 23, 2023

Conversation

9mm
Copy link
Contributor

@9mm 9mm commented Dec 18, 2023 •
edited

What kind of change does this PR introduce?

Attempts fixing #2187 and a temporary solution to #2147 until a better solution is issued

Fixes #1987 temporarily

Did this PR introduce a breaking change?

  • No

fredizzimo
fredizzimo approved these changes Dec 18, 2023
View reviewed changes
Copy link
Member

@fredizzimo fredizzimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. But leaving open for a while for testing and additional comments.

@9mm
Copy link
Contributor Author

9mm commented Dec 19, 2023

Sorry wrote this in the wrong issue:

I did actually find `cargo bundle --release` from the Readme, somehow I missed that the first time.

When I build this bundle and drag to dock, and place the env variable with the others, it works!

So that makes me super happy, the dock does not double bounce

Im going to work on drag and drop files next

MultisampledNight
MultisampledNight reviewed Dec 23, 2023
View reviewed changes
src/cmd_line.rs Outdated Show resolved Hide resolved
@MultisampledNight MultisampledNight changed the title NEOVIDE_FORK environment variable feat: NEOVIDE_FORK environment variable Dec 23, 2023
@MultisampledNight
Copy link
Contributor

Thank you! Choooooooooooooooooooooooooooo choooooooo 🚂!

@MultisampledNight MultisampledNight merged commit a1d0af6 into neovide:main Dec 23, 2023
3 checks passed
@MultisampledNight MultisampledNight mentioned this pull request Dec 23, 2023
Closed
@MultisampledNight MultisampledNight linked an issue Dec 23, 2023 that may be closed by this pull request
Allow setting Fork behavior in ENV variable #2187
Closed
@razvanazamfirei razvanazamfirei mentioned this pull request Dec 24, 2023
Merged
@valleydali valleydali mentioned this pull request Jan 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MultisampledNight MultisampledNight MultisampledNight left review comments

@fredizzimo fredizzimo fredizzimo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow setting Fork behavior in ENV variable Neovide.app seems non-standard boot method?
3 participants
@9mm @MultisampledNight @fredizzimo