fix: bug of restoring window position on macos. #2345
Merged
+5
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@crupest thank you for troubleshooting! but could you share some video/gif? I am not able to reproduce on macOS Sonoma. does it occurs with Stage Manager enabled/disabled? |
|
It's strange that the function works differently on macOS, and then they have another function that makes it work the same... I guess Winit did not want to break backwards compatibility or something. |
falcucci
changed the title
falcucci
approved these changes
Feb 7, 2024
|
@fredizzimo Approved. that's what I have thought as well. |
According to winit docs, `with_position` sets the position of top left corner of *content* rect instead of *window* rect on macOS, so a `set_outer_position` call is needed.
crupest
force-pushed
the
macos-window-position
branch
from
7378d51
to
3492f0b
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2303
According to winit docs at https://docs.rs/winit/latest/winit/window/struct.WindowBuilder.html#method.with_position,
with_positionsets the position of top left corner of content rect instead of window rect on macOS, so aset_outer_positioncall is needed.