Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update lru crate to fix building with the nightly toolchain #2346

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

fredizzimo
Copy link
Member

@fredizzimo fredizzimo commented Feb 7, 2024

What kind of change does this PR introduce?

Updates the lru package from 0.7.5 to 0.12.2.

The old package caused an old hasbrown version to be used, which in turn caused an old version of ahash to be used, which does not build on the current nightly version of the rust toolchain.

Did this PR introduce a breaking change?

  • No

@fredizzimo
Copy link
Member Author

We should find some way to keep our dependencies up to date, and at least try to prevent having multiple versions of the same dependencies in our lockfile. In this case we had duplicates of both hashbrown and ahash

@fredizzimo
Copy link
Member Author

Winit also pulls in a lot of unneeded stuff, wasm, some web stuff and and android-activity for example.

@fredizzimo
Copy link
Member Author

I will try to clean up some other duplicates as well in this PR, so putting it into draft for now

@fredizzimo fredizzimo marked this pull request as draft February 7, 2024 20:34
@fredizzimo
Copy link
Member Author

Let's ignore that, in many cases it does not seem to be possible, and I think we need some tooling for this rather than doing it by hand.

@fredizzimo fredizzimo marked this pull request as ready for review February 7, 2024 20:57
@Kethku Kethku merged commit 4cd9a6b into neovide:main Feb 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants