fix: set startup directory failed is not an error

[TwIStOy]

Fix launching neovide with a "fake" neovim instance neovide --neovim-bin nvim.dev.local:

nvim.dev.local:

#!/bin/bash
ssh dev.local "bash -l -c \"nvim $@\"" 

What kind of change does this PR introduce?

• Fix

Did this PR introduce a breaking change?

• No

[Kethku]

Seems good to me. Ty

[fredizzimo]

It's a reasonable fix, but I think there's another bug hiding here. The startup directory is not supposed to be set based on the --neovim-bin argument, only based on actual files and directories passed as arguments.

@falcucci

[falcucci]

this is indeed a good missing error treatment.

It's a reasonable fix, but I think there's another bug hiding here. The startup directory is not supposed to be set based on the --neovim-bin argument, only based on actual files and directories passed as arguments.

I think it has nothing with --neovim-bin and also the startup dir should follow for non tty only.

I am just not able to replicate it just creating that "fake" neovim instance as mentioned.

A startup path must be given somehow.

the following command wouldn't be even considered as a non tty:

neovide --neovim-bin nvim.dev.local

I have created an instance as a connected fake server and nothing wrong happened aswell,

It also depends about the platform. macOS would take $HOME in this case and execute it.

So I cannot suppose a hided bug here, we need to replicate it first.