Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Temporary hang after sleep #2472

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

fredizzimo
Copy link
Member

What kind of change does this PR introduce?

This fixes a bug where Neovide stops responding for some time after the computer has gone to sleep or disconnected from a remote desktop.

There are actually two different fixes:

  1. Properly prepare the frame before respecting OS or Winit initiated rendering requests. This fixes the main bug at least when disconnecting from the remote desktop on Windows.
  2. Don't simulate for more than 1 second. I don't know how to trigger this in practice, but I suspect it can happen if the computer goes to sleep while Neovide is animating. I tested this by disabling fix 1.

NOTE: Marked as draft since it depends on and should be reviewed and merged after that

Did this PR introduce a breaking change?

  • No

@Kethku
Copy link
Member

Kethku commented Apr 15, 2024

This needs rebased on main before I can easily review it as changes are mixed between the update loop changes and the actual fixes in this PR

@fredizzimo fredizzimo force-pushed the fsundvik/fix-temp-hang-after-sleep branch from 0a644d3 to 6a19539 Compare April 15, 2024 06:51
@fredizzimo fredizzimo marked this pull request as ready for review April 15, 2024 06:51
Copy link

Test Results

  6 files  ±0    6 suites  ±0   21s ⏱️ +3s
107 tests ±0  107 ✅ ±0  0 💤 ±0  0 ❌ ±0 
630 runs  ±0  630 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 6a19539. ± Comparison against base commit 41622dc.

@Kethku Kethku merged commit 115afde into neovide:main Apr 18, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants