Refactor the registry-relevant functions. #2490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The right click menu register functions are refactored with `windows` crate. The refactored code seems simpler and easier to be read and maintained.
|
I think this commit could be a good start to migrate from |
fredizzimo
requested changes
Apr 20, 2024
|
I think it would be worth having another go trying the It's new, so there's a small possibility that it is broken, but I don't see any bug reports about it, so I think that chance is very low. It's not very widely used, but still there's 2000 downloads the past 90 days, so I would think that someone else has encountered issues. |
|
Hi @fredizzimo , I've finished changing the logics. |
fredizzimo
reviewed
Apr 22, 2024
fredizzimo
approved these changes
Apr 23, 2024
|
Thank you, this did indeed simplify the code a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The right click menu register functions are refactored with
windowsandwindows-registrycrates. The refactored code seems simpler and easier to be read and maintained.What kind of change does this PR introduce?
Did this PR introduce a breaking change?